Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any reason not to use the official clang-format package? #2202

Closed
Sarcasm opened this issue Nov 26, 2014 · 3 comments · Fixed by #2399
Closed

Is there any reason not to use the official clang-format package? #2202

Sarcasm opened this issue Nov 26, 2014 · 3 comments · Fixed by #2399

Comments

@Sarcasm
Copy link
Contributor

Sarcasm commented Nov 26, 2014

Hello,

I see that the clang-format recipe added in the pull request #1654 doesn't link to the official clang-format.el. Is there any reason? The Clang folks are very active and friendly, if the official clang-format.el doesn't is missing some piece it should be improved.

If I want to depend on clang-format on the future I don't want to have 2 different packages with the same name but different interface.

Any thought @kljohann?

At least the package should be renamed IMHO.

The official clang-format.el is located here: https://llvm.org/svn/llvm-project/cfe/trunk/tools/clang-format/clang-format.el

Best,
Guillaume

@purcell
Copy link
Member

purcell commented Nov 26, 2014

The official clang-format.el would indeed be preferable. It is currently not a well-formatted package, though, so it would need fixing up. Perhaps @kljohann could volunteer to be the official maintainer, and take care of syncing his changes into the llvm repo?

@kljohann
Copy link
Contributor

Sure, sounds like the best way to go forward. Apart from the package.el header, my version provides defcustoms, so one does not have to go around editing the original file (which would not work well for use as a package). A quick glance suggests that the behaviour should be roughly the same, apart from some compatibility functions I'd have to add.
I don't know when I'll have time to do this, though. At the latest during the holidays, I hope. I'll open a separate issue at https://github.com/kljohann/clang-format.el to remind me.

@purcell
Copy link
Member

purcell commented Nov 26, 2014

Thanks. I'll leave this open and we can review it in the new year. :-)

kljohann added a commit to kljohann/melpa that referenced this issue Jan 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants