Add demo-it package to recipes

[howardabrams]

A collection of utility functions for creating demonstrations and
presentations from within Emacs.

For details, see https://github.com/howardabrams/demo-it.git

[purcell]

Thanks - interesting stuff!

There are quite a few issues here which need to be addressed before we can add the package.

• File isn't formatted as a package: it lacks the requisite header boilerplate, for a start. Try enabling auto-insert-mode, then create a fresh demo-it.el to see how that should look, and finally insert your code into that new conformant template.
• The recipe as-is would bundle example.el into the package, which is undesirable. Consider putting example.el in an examples subdir to solve this. Otherwise, you'd have to list only demo-it.el in the recipe.
• The mix of demo-it/ and demo-it- identifier prefixes serves no obvious purpose and is unidiomatic. It's conventional to occasionally use / or -- to denote package-internal identifiers, but that doesn't seem to be what you're doing here. I suggest you just use the conventional demo-it- prefix style throughout.
• You shouldn't just global-set-key bindings at the top level. Either provide the user with a function which will initialize the bindings at a time of his choosing, or define a quick global mode which has the bindings in its mode map: this would be the cleanest option.
• You should avoid defining unprefixed identifiers, e.g. autofeaturep, hide-mode-line etc.
• autofeaturep itself uses an unreliable approach. Use (eval-after-load 'expand-region (progn ...your code here...)) instead.
• defvar-local is not available in Emacs < 24. I strongly suggest you just use defvar combined with make-variable-buffer-local in order to maximise compatibility.

Hope that helps!

-Steve

[howardabrams]

Thanks for the feedback! I'll get back to you on those.

[howardabrams]

Alright, I think I have cleaned up the project significantly. @purcell, do you notice anything else I should address?

Thanks again for the feedback.

[purcell]

Nope, looks great!

[purcell]

I've committed a slightly different recipe, using the github fetcher shorthand.

[howardabrams]

Sounds just fine. Thanks, again!

[purcell]

Package page is here, BTW: http://melpa.milkbox.net/#/demo-it