Set <title> tag with the title of the current page on melpa.org #2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, yes, I'd also like this to work properly! Not sure that this is quite the ideal implementation, since the |
|
Cool, thanks. FWIW, it may make more sense to use
|
|
Done in a more verbose but perhaps slightly cleaner way in 6eb07d6. Should take effect within a couple of hours. |
jeffgran
pushed a commit
to jeffgran/melpa
that referenced
this pull request
Jan 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the
<title>tag with the title of the current page. So if you're on a specific package's page you'll actually see that package's name+version in your browser's tab and more importantly when you're going through your browser history (which was my motivation for this PR).Right now it's using
|as the separator and I am not 100% sure version should be part of the title, but I do think something like this should be done regardless of style/content decisions. Thoughts?This PR was tested on the most recent versions of Chrome, Firefox, and Safari on a Mac.