Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

few suggestions #39

Closed
vujovicigor opened this issue Jan 14, 2016 · 1 comment
Closed

few suggestions #39

vujovicigor opened this issue Jan 14, 2016 · 1 comment

Comments

@vujovicigor
Copy link

Great work guys, milligram is fantastic.
Here is few suggestions:

  • when select element is open, default browser color is used, it can be fixed:
option:checked
    background: linear-gradient($color-primary, $color-primary)
  • onclick effect:
.button:active, button:active, input[type="button"]:active, input[type="submit"]:active, input[type="reset"]:active
    transition: none
    opacity: 0.7
  • some transitions:
.button, button, input, textarea, select
    transition: border 0.3s, background-color 0.3s, color 0.3s
  • responsive img:
img
    height: auto
    max-width: 100%
  • media query to reset max-width on small screen devices:
// Smaller than mobile screen
@media (max-width: 40.0rem)
    .row
        flex-direction: column
        .column
            max-width: 100%

        .column
            &.column-10, &.column-20, &.column-33, &.column-34, &.column-40, &.column-50, &.column-60, &.column-66, &.column-67, &.column-75, &.column-80, &.column-90
                max-width: 100%

here is example:
http://codepen.io/vujovichigor/pen/NxvoOR
(try resizing browser)

Thank you for milligram :)

@cjpatoilo
Copy link
Member

@vujovicigor Thanks for the suggestions, some have already been submitted, I will be providing other and they become available in the next update. =D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants