Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SeriesDataHelper does only return 20 datasets #33

Closed
gb5256 opened this issue Feb 12, 2016 · 4 comments
Closed

SeriesDataHelper does only return 20 datasets #33

gb5256 opened this issue Feb 12, 2016 · 4 comments
Labels

Comments

@gb5256
Copy link

gb5256 commented Feb 12, 2016

I have just noticed that the SeriesDataHelper does only return the first 20 datasets.
Is this by design?

@nlrooat
Copy link

nlrooat commented Feb 17, 2016

20 is the default value for the $dataprovider. Try

$dataProvider = new ActiveDataProvider([
    'query' => $query,
    'pagination' => false,
    //'pagination' => [
    //    'pageSize' => 20,
    //],
]);

false will disable pagination. Or uncomment the commented lines (and remove the other 'pagination' entry) and change 20 to any other value you like.

@miloschuman
Copy link
Owner

Thanks for the help, @nlrooat.

@gb5256
Copy link
Author

gb5256 commented May 25, 2016

No, sorry to say but that is not the problem.
I am creating the array with a $query = (new \yii\db\Query()) and not with a ActiveDataProvider.
So there is no pagination used which could be set 20.
So I would like to re-open this issue.
gb5256

@miloschuman
Copy link
Owner

You're right, @gb5256. If you pass SeriesDataHelper an array, that array gets populated into an intermediate ArrayDataProvider, which has a default pageSize of 20. I'll include a fix in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants