Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require password to edit, delete, create reservations #3

Open
3 tasks
milotoor opened this issue Aug 6, 2020 · 0 comments
Open
3 tasks

Require password to edit, delete, create reservations #3

milotoor opened this issue Aug 6, 2020 · 0 comments

Comments

@milotoor
Copy link
Owner

milotoor commented Aug 6, 2020

There is currently (weak; see #2) security around fetching the full details of existing reservations, but there is no password required to create, edit or delete a reservation. Editing and deleting requires having an existing reservation's ID, which can't be obtained without the password; nevertheless it's poor form to have these endpoints unsecured.

  • Refactor the router to be a class with add, edit, delete, get and getBasic methods.
  • Write a decorator function require_auth which can wrap the above methods to secure them. The logic for this function can be taken from the current get_reservations file.
  • Apply the new decorator to the add, edit, delete and get methods.
@milotoor milotoor added this to To do in Improvements via automation Aug 6, 2020
@milotoor milotoor moved this from To do to In progress in Improvements Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Improvements
  
In progress
Development

No branches or pull requests

1 participant