Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build breaks with clang when examples are enabled #761

Closed
yurivict opened this issue Oct 4, 2016 · 4 comments
Closed

Build breaks with clang when examples are enabled #761

yurivict opened this issue Oct 4, 2016 · 4 comments

Comments

@yurivict
Copy link

yurivict commented Oct 4, 2016

Errors:

/usr/ports/devel/rapidjson/work/rapidjson-1.1.0/include/rapidjson/pointer.h:803:36: error: 'nullptr' is incompatible with C++98 [-Werror,-Wc++98-compat]
        RAPIDJSON_ASSERT(source != NULL);

Adding this optiojn -Wno-c++98-compat helps.

@miloyip
Copy link
Collaborator

miloyip commented Oct 5, 2016

It looks strange as nullptr is not used in in pointer.h and other headers.
How did you build the examples?

@yurivict
Copy link
Author

yurivict commented Oct 5, 2016

Added -DRAPIDJSON_BUILD_EXAMPLES:BOOL=ON argument to cmake, and then ran make.

@jbeich
Copy link

jbeich commented Oct 9, 2016

freebsd/freebsd-src@c8ed04c behavior affects FreeBSD since 10.0. It seems Clang's -Weverything adds -Wc++98-compat even in -std=c++11 mode. I wonder what type of spaghetti code Clang expects.

@piratf
Copy link
Collaborator

piratf commented Oct 8, 2019

This issue was temporarily closed due to no response for a long time.

Please try checking it out according to the reply above.

@piratf piratf closed this as completed Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants