Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial: fix typos in examples and broken links #1002

Merged
merged 2 commits into from Jul 10, 2017

Conversation

FluxLemur
Copy link
Contributor

In the move example, the code uses contacts when the diagrams use
contact (no 's')

The code in the example:

    // adding elements to contacts array.
    // ...
    o.AddMember("contacts", contacts, d.GetAllocator());  // deep clone contacts (may be with lots of allocations)
    // destruct contacts.

In the move example, the code uses `contacts` when the diagrams use
`contact` (no 's')

The code in the example:
```    Value contacts(kArrayType);
    // adding elements to contacts array.
    // ...
    o.AddMember("contacts", contacts, d.GetAllocator());  // deep clone contacts (may be with lots of allocations)
    // destruct contacts.
```
@coveralls
Copy link

coveralls commented Jun 30, 2017

Coverage Status

Coverage remained the same at 99.938% when pulling 0d62f5c on FluxLemur:patch-1 into 2f45319 on miloyip:master.

@miloyip
Copy link
Collaborator

miloyip commented Jun 30, 2017

The paths in links are necessary for doxygen to generate HTML in http://rapidjson.org.

@FluxLemur
Copy link
Contributor Author

Ah I see. It's too bad it's broken in github, but certainly better to have a proper doxygen generated website.

I'll undo the path changes.

@coveralls
Copy link

coveralls commented Jun 30, 2017

Coverage Status

Coverage remained the same at 99.938% when pulling 3aafe12 on FluxLemur:patch-1 into 2f45319 on miloyip:master.

@miloyip miloyip merged commit 4da20e2 into Tencent:master Jul 10, 2017
@miloyip
Copy link
Collaborator

miloyip commented Jul 10, 2017

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants