Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some usage of rvalue references #742

Closed
wants to merge 1 commit into from

Conversation

0x1997
Copy link

@0x1997 0x1997 commented Sep 21, 2016

std::move is missing in a few places.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 99.936% when pulling be54944 on 0x1997:missing-move into f28203c on miloyip:master.

@pah
Copy link
Contributor

pah commented May 18, 2017

These explicit std::moves are not needed due to RapidJSON's default use of move semantics. They are even harmful, because they lead to an infinite recursion. ;-)

@0x1997
Copy link
Author

0x1997 commented May 19, 2017

@pah I see. Thanks.

@0x1997 0x1997 closed this May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants