Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arch specific compiler flags. #756

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AdamMajer
Copy link
Contributor

While we are not really building anything that is distributed,
these compiler flags don't exist on all architectures.

On PPC this dies with.
c++: error: unrecognized command line option '-march=native'; did you mean '-mcpu=native'?

While we are not really building anything that is distributed,
these compiler flags don't exist on all architectures.

On PPC this dies with.
  c++: error: unrecognized command line option '-march=native'; did you mean '-mcpu=native'?
@coveralls
Copy link

coveralls commented Sep 30, 2016

Coverage Status

Coverage remained the same at 99.937% when pulling 29a9313 on AdamMajer:remove_arch_flags into ffc7942 on miloyip:master.

@miloyip
Copy link
Collaborator

miloyip commented Oct 1, 2016

Can you find out before which gcc version this is not supported? And then just disable it when it is not supported? (I don't know if cmake can automatically detect this.)
-march=native is needed to test most optimized code.

@AdamMajer
Copy link
Contributor Author

On 10/01/2016 09:49 AM, Milo Yip wrote:

Can you find out before which gcc version this is not supported? And
then just disable it when it is not supported? (I don't know if cmake
can automatically detect this.)
|-march=native| is needed to test most optimized code.

This applies to architectures, not compiler versions. I think it is
failing on PPC64 and some other that do not have that flag. I'll look
for a better way of disabling this on unsupported arches.

Cheers,
Adam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants