Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve nuget publishing workflow #73

Open
roji opened this issue Mar 28, 2024 · 3 comments
Open

Improve nuget publishing workflow #73

roji opened this issue Mar 28, 2024 · 3 comments

Comments

@roji
Copy link
Collaborator

roji commented Mar 28, 2024

The current Github Actions Nuget publish workflow looks like it publishes any tag to nuget.org, which seems problematic - we should be able to use tags for other purposes as well without a nuget package immediately getting pushed to nuget.org.

At the very least, we should perform the deployment via a Github environment; this environment would require manual authorization for pushing to nuget.org, and would ideally also contain the nuget.org key secret (presumably currently defined in the organization)

@yhmo @weianweigan who would be a good person with permissions to create the Github organization and configure it appropriately?

@weianweigan
Copy link
Collaborator

@roji, that sounds good! I looked at the Settings tab but didn't see any environment options. It appears I don't have the necessary permissions to access it. It's possible that only @yhmo has access currently.

@yhmo
Copy link
Collaborator

yhmo commented Mar 29, 2024

@yhmo
Copy link
Collaborator

yhmo commented Mar 29, 2024

An environment is added:
Screenshot from 2024-03-29 14-30-56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants