Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Not consistent with official documentation]listBulkInsertTasks() CollectionName NULL check #469

Closed
fall-nebula opened this issue Apr 6, 2023 · 1 comment

Comments

@fall-nebula
Copy link

fall-nebula commented Apr 6, 2023

In official documentation said List all tasks Parameter [collection_name ] is optional. And said "Leave the value empty if you want to list all tasks recorded by Milvus root coords".
Docs
But in io.milvus.client.AbstractMilvusGrpcClient#listBulkInsertTasks used:

            ListImportTasksRequest listImportTasksRequest = ListImportTasksRequest.newBuilder()
                    .setCollectionName(requestParam.getCollectionName())
                    .setLimit(requestParam.getLimit())
                    .build();

And io.milvus.grpc.ListImportTasksRequest.Builder#setCollectionName don't allow value is null.

    public ListImportTasksRequest.Builder setCollectionName(
            java.lang.String value) {
        if (value == null) {
            throw new NullPointerException();
        }

        collectionName_ = value;
        onChanged();
        return this;
    }
@yhmo
Copy link
Contributor

yhmo commented Jun 30, 2023

Fixed by this pr, which will be released in v2.2.9

@yhmo yhmo closed this as completed Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants