Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet creation failed #34

Closed
flomang opened this issue Dec 13, 2022 · 1 comment
Closed

Wallet creation failed #34

flomang opened this issue Dec 13, 2022 · 1 comment

Comments

@flomang
Copy link
Collaborator

flomang commented Dec 13, 2022

Creating any new wallets at the moment results in a lifecycle error.
@flomang
Copy link
Collaborator Author

flomang commented Dec 14, 2022 •
edited

Well, it seems the to_mnemonic function of WalletSeed (grin-wallet - src/lifecycle/seed.rs) is throwing the error because the vec in WalletSeed is empty sometimes. I must be in some strange condition as I can generate a testnet wallet successfully but generating a mainnet wallet seems to result in the wallet seed never populating.

Further investigation reveals that the seed decrypt function is popping the encrypted_seed in the final loop causing the vec to be empty in the WalletSeed::from_bytes(...) call.

I see it now. what should the recovery_phrase be defaulted to. I think I had 32 before. Seems the seed_length was being sent in as 0 for mainnet but the logic is different for testnet init_new of seed.rs.

@flomang flomang mentioned this issue Dec 14, 2022
Merged
@flomang flomang closed this as completed Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flomang