New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aggsig verify: inefficiently allocation every time #27

Open

garyyu opened this issue Sep 26, 2018 · 1 comment

Labels

Contributor

garyyu commented Sep 26, 2018

https://github.com/mimblewimble/secp256k1-zkp/blob/master/src/modules/aggsig/main_impl.h#L498-L499

    /* just going to inefficiently allocate every time */
    secp256k1_scratch_space *scratch = secp256k1_scratch_space_create(ctx, 1024*4096);

Mark here: This line need an optimization, to avoid 4M bytes RAM allocation on each call. Will give a PR on this.

The text was updated successfully, but these errors were encountered:

garyyu added the enhancement label

Contributor Author

garyyu commented Sep 26, 2018

Another place: https://github.com/mimblewimble/secp256k1-zkp/blob/master/src/modules/aggsig/main_impl.h#L566

    scratch = secp256k1_scratch_space_create(ctx, 1024*4096);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment