-
Notifications
You must be signed in to change notification settings - Fork 4
/
error_handler.go
364 lines (332 loc) · 10.3 KB
/
error_handler.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
// Copyright 2023 MIMIRO AS
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package jobs
import (
"context"
"errors"
"strings"
"time"
"github.com/mimiro-io/datahub/internal/server"
)
const (
ErrorHandlerReRun = "rerun"
ErrorHandlerReQueue = "requeue"
ErrorHandlerLog = "log"
)
var ErrorHandlerTypes = map[string]bool{ErrorHandlerReRun: true, ErrorHandlerReQueue: true, ErrorHandlerLog: true}
type ErrorHandler struct {
Type string `json:"errorHandler"` // rerun, requeue, log
MaxRetries int `json:"maxRetries"` // default 1
RetryDelay int64 `json:"retryDelay"` // seconds, default 30
MaxItems int `json:"maxItems"` // 0 = all
failingEntityHandler failingEntityHandler
}
func (h *ErrorHandler) init(dsm *server.DsManager) {
if h.failingEntityHandler != nil && h.Type == ErrorHandlerReQueue {
feh, ok := h.failingEntityHandler.(*ReQueueFailingEntityHandler)
if ok {
feh.dsm = dsm
}
}
}
type failingEntityHandler interface {
handleFailingEntity(runner *Runner, entity *server.Entity, jobId string) error
reset()
}
type LogFailingEntityHandler struct {
count int
MaxItems int
jobTitle string
jobId string
}
func (l *LogFailingEntityHandler) reset() {
l.count = 0
}
func (l *LogFailingEntityHandler) handleFailingEntity(runner *Runner, entity *server.Entity, jobId string) error {
runner.logger.With(
"job.jobId", l.jobId,
"job.jobTitle", l.jobTitle,
"job.state", "Failing",
).Warnf("entity %v failed to process: %+v", entity.ID, entity)
l.count = l.count + 1
if l.MaxItems > 0 && l.count >= l.MaxItems {
return MaxItemsExceededError
}
return nil
}
type ReQueueFailingEntityHandler struct {
count int
MaxItems int
queue *reQueue
dsm *server.DsManager
}
func (r *ReQueueFailingEntityHandler) reset() {
r.count = 0
r.queue = nil
}
func (r *ReQueueFailingEntityHandler) handleFailingEntity(runner *Runner, entity *server.Entity, jobId string) error {
if r.MaxItems > 0 && r.count >= r.MaxItems {
return MaxItemsExceededError
}
r.count = r.count + 1
runner.logger.Warnf("entity %v failed to process, requeueing", entity.ID)
if r.queue == nil {
q, err := newReQueue(jobId, r.dsm)
if err != nil {
return err
}
r.queue = q
}
return r.queue.enQueue(entity)
}
type wrappedTransform struct {
t Transform
failingEntityHandlers []failingEntityHandler
jobId string
}
type wrappedSink struct {
s Sink
failingEntityHandlers []failingEntityHandler
jobId string
lastError error
lastProcessed int
recursionDepth int
}
// verifyErrorHandlers checks that the error handlers are valid, and also
// sets default values for the error handlers
func verifyErrorHandlers(trigger JobTrigger, id string, title string) error {
counts := make(map[string]int)
if len(trigger.ErrorHandlers) > 0 {
for _, eh := range trigger.ErrorHandlers {
// fix casing
eh.Type = strings.ToLower(eh.Type)
if _, ok := counts[eh.Type]; ok {
return errors.New("duplicate error handler: " + eh.Type)
}
counts[eh.Type] = 1
if _, ok := ErrorHandlerTypes[eh.Type]; !ok {
return errors.New("need to set 'errorHandler'. must be one of: reRun, reQueue, log")
}
// set defaults
switch eh.Type {
case ErrorHandlerReRun:
if eh.MaxRetries == 0 {
eh.MaxRetries = 1
}
if eh.RetryDelay == 0 {
eh.RetryDelay = 30
}
eh.RetryDelay = int64(time.Second) * eh.RetryDelay
case ErrorHandlerLog:
eh.failingEntityHandler = &LogFailingEntityHandler{MaxItems: eh.MaxItems, jobId: id, jobTitle: title}
case ErrorHandlerReQueue:
eh.failingEntityHandler = &ReQueueFailingEntityHandler{MaxItems: eh.MaxItems}
default:
return errors.New("unknown error handler: " + eh.Type)
}
}
}
return nil
}
// handleJobError is called after a job run has completed. if the run ended with an error, this function
// will schedule a rerun if configured
func (j *job) handleJobError(err *error) {
if err == nil || *err == nil || *err == MaxItemsExceededError {
if wrappedSink, isWrapped := j.pipeline.spec().sink.(*wrappedSink); isWrapped {
if wrappedSink.lastError != nil {
*err = wrappedSink.lastError
lastRun := &jobResult{}
_ = j.runner.store.GetObject(server.JobResultIndex, j.id, lastRun)
lastRun.LastError = (*err).Error()
if lastRun.Processed > wrappedSink.lastProcessed {
wrappedSink.lastProcessed = lastRun.Processed
}
lastRun.Processed = wrappedSink.lastProcessed
_ = j.runner.store.StoreObject(server.JobResultIndex, j.id, lastRun)
j.runner.logger.Warnw("job %v (%v) completed, but errors occurred: %w", j.title, j.id, *err)
} else {
return
}
} else {
j.runner.logger.Debugf("job %v (%v) completed successfully", j.title, j.id)
return
}
}
if err != nil && *err != nil && (*err).Error() == "got job interrupt" {
j.runner.logger.Debugf("job %v (%v) interrupted", j.title, j.id)
return
}
if j.errorHandlers != nil {
for _, eh := range j.errorHandlers {
if eh.Type == ErrorHandlerReRun {
if eh.MaxRetries > 0 {
eh.MaxRetries = eh.MaxRetries - 1
time.AfterFunc(time.Duration(eh.RetryDelay), func() {
j.runner.logger.Infof("re-running job %v (%v). Try number %v", j.title, j.id, eh.MaxRetries)
// j.pipeline.sync(j, ctx)
j.Run()
})
}
return
}
}
}
}
func (j *job) instrumentErrorHandling() {
if j.errorHandlers != nil {
failingEntityHandlers := make([]failingEntityHandler, 0)
for _, eh := range j.errorHandlers {
// TODO: excluded reQueue handler for now. first release only supports reRun and log
if eh.Type == ErrorHandlerLog { //|| eh.Type == ErrorHandlerReQueue {
failingEntityHandlers = append(failingEntityHandlers, eh.failingEntityHandler)
}
}
if len(failingEntityHandlers) == 0 {
return
}
if j.pipeline.spec().transform != nil {
wrapped, isWrapped := j.pipeline.spec().transform.(*wrappedTransform)
if !isWrapped {
j.pipeline.spec().transform = &wrappedTransform{
j.pipeline.spec().transform, failingEntityHandlers,
j.id,
}
} else {
wrapped.reset()
}
}
wrapped, isWrapped := j.pipeline.spec().sink.(*wrappedSink)
if !isWrapped {
j.pipeline.spec().sink = &wrappedSink{
s: j.pipeline.spec().sink, failingEntityHandlers: failingEntityHandlers, jobId: j.id,
}
} else {
wrapped.reset()
}
}
// TODO: excluded reQueue handler for now. first release only supports reRun and log
//j.pipeline.spec().source = &reQueuePrependingSource{s: j.pipeline.spec().source, jobId: j.id, dsm: j.dsm}
}
func (w *wrappedTransform) GetConfig() map[string]interface{} {
return w.t.GetConfig()
}
func (w *wrappedTransform) transformEntities(runner *Runner, entities []*server.Entity, jobTag string) ([]*server.Entity, error) {
transformedEntities, err := w.t.transformEntities(runner, entities, jobTag)
//if err != nil {
// splitPoint := len(entities) / 2
// left := entities[:splitPoint]
// leftResult, leftErr := w.transformEntities(runner, left, jobTag)
// if leftErr != nil && len(entities) <= 1 {
// for _, eh := range w.failingEntityHandlers {
// for _, entity := range entities {
// err2 := eh.handleFailingEntity(runner, entity, w.jobId)
// if err2 != nil {
// return nil, err2
// }
// }
// }
// }
//
// right := entities[splitPoint:]
// rightResult, rightErr := w.transformEntities(runner, right, jobTag)
// if rightErr != nil && len(entities) <= 1 {
// for _, eh := range w.failingEntityHandlers {
// for _, entity := range entities {
// err2 := eh.handleFailingEntity(runner, entity, w.jobId)
// if err2 != nil {
// return nil, err2
// }
// }
// }
// }
//
// return append(leftResult, rightResult...), nil
//}
return transformedEntities, err
}
func (w *wrappedTransform) getParallelism() int {
return w.t.getParallelism()
}
func (w *wrappedTransform) reset() {
for _, eh := range w.failingEntityHandlers {
eh.reset()
}
}
func (w *wrappedSink) GetConfig() map[string]interface{} {
return w.s.GetConfig()
}
var MaxItemsExceededError = errors.New("errorHandler: max items reached")
func (w *wrappedSink) processEntities(runner *Runner, entities []*server.Entity) error {
// try to run batch
err := w.s.processEntities(runner, entities)
if err != nil {
// if this was a single entity, and it failed, run handles
if len(entities) <= 1 {
for _, eh := range w.failingEntityHandlers {
for _, entity := range entities {
err2 := eh.handleFailingEntity(runner, entity, w.jobId)
if err2 != nil {
if w.lastError == nil {
w.lastError = err
}
return err2
// return w.lastError
}
}
}
if !errors.Is(err, MaxItemsExceededError) {
w.lastError = err
}
return nil
} else {
// if this was a larger batch, split and recusrse
w.recursionDepth++
splitPoint := len(entities) / 2
left := entities[:splitPoint]
leftErr := w.processEntities(runner, left)
if !errors.Is(leftErr, MaxItemsExceededError) {
right := entities[splitPoint:]
rightErr := w.processEntities(runner, right)
if rightErr != nil && !errors.Is(rightErr, MaxItemsExceededError) {
w.lastError = rightErr
}
if errors.Is(rightErr, MaxItemsExceededError) {
return rightErr
}
}
if leftErr != nil && !errors.Is(leftErr, MaxItemsExceededError) {
w.lastError = leftErr
}
return leftErr
}
} else {
// unset error if this was an unsplit batch without failure
if w.recursionDepth == 0 {
w.lastError = nil
}
}
return nil
}
func (w *wrappedSink) startFullSync(runner *Runner) error {
return w.s.startFullSync(runner)
}
func (w *wrappedSink) endFullSync(ctx context.Context, runner *Runner) error {
return w.s.endFullSync(ctx, runner)
}
func (w *wrappedSink) reset() {
w.recursionDepth = 0
for _, eh := range w.failingEntityHandlers {
eh.reset()
}
}