Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinLenght #82

Closed
lpalomo opened this issue Oct 30, 2014 · 12 comments
Closed

MinLenght #82

lpalomo opened this issue Oct 30, 2014 · 12 comments

Comments

@lpalomo
Copy link

lpalomo commented Oct 30, 2014

Hi, I was wondering if you are open to adding a "minLenght" warning to the plugin (I think it doesn't support this already). Just a warning, no validation; for example, if the input length is less than N then show the widget label in red or yellow, and if the input length is longer or equal than N then show the widget label in green.

@BtM909
Copy link

BtM909 commented Jul 13, 2015

I've actually added a warning treshold you can specifiy. This allows you to have 3 states (OK, Warning and Threshold). I assume it's very easy to add for @mimo84, otherwise I can do a pull request.

/edit
It seems that v1.6.0 has something similar built in.

/edit
Actually, there's no functionality for this, so let me know if I need to do a pull request.

@mimo84
Copy link
Owner

mimo84 commented Oct 10, 2015

If you have something for this please do open a PR, also please make sure to add some tests around the functionality.

@dciancu
Copy link

dciancu commented Jan 23, 2016

+1
I find it really useful.

@BtM909 Are you still up with the PR?

@diego3
Copy link

diego3 commented Apr 19, 2016

+1 It is really very usefull

@BtM909
Copy link

BtM909 commented Apr 19, 2016

I completely missed this... I'll craft up some PR (probably this weekend)

@justincorrigible
Copy link
Contributor

How'd it go @BtM909? I'm working on this feature for I need it at work... wanna pair up for the PR?

@BtM909
Copy link

BtM909 commented Aug 30, 2016

I have changed it locally, but haven't able to find time to create a PR (which I assume, should include some (unit-)testing).

@BtM909
Copy link

BtM909 commented Aug 30, 2016

@hallaathrad, we can definitly work together for this PR. ping me an email @gmail.com.

@justincorrigible
Copy link
Contributor

knock knock

@johnabela
Copy link

whos there

@BtM909
Copy link

BtM909 commented Mar 27, 2017

@hallaathrad was a bit busy. Let's see if he has some more time right now?

@mimo84
Copy link
Owner

mimo84 commented Mar 3, 2020

This issue has been inactive for a while. If you want to work on it and open a PR feel free to do so!

@mimo84 mimo84 closed this as completed Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants