Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consult-mark, consult-line, consult-outline should highlight matches in preview #7

Closed
minad opened this issue Nov 29, 2020 · 2 comments
Labels
feature New feature or request

Comments

@minad
Copy link
Owner

minad commented Nov 29, 2020

While the current line is highlighted, the matched strings are not. The current completion style or the selectrum highlight filter should be used to obtain the highlights.

@minad
Copy link
Owner Author

minad commented Dec 4, 2020

@oantolin Since you wrote the orderless package (which I am also using btw), I wonder if you know a generic way of obtain the matches of the current completion, in order to show them in the buffer for preview, additionally to being shown already in the minibuffer. I haven't found something obvious quickly but I didn't dig very deep.

@minad
Copy link
Owner Author

minad commented Dec 21, 2020

I think this can be implemented as follows:

  1. Obtain the completion candidate stringvia all-completions, orderless will highlight the matches via face properties
  2. Extract face properties and create overlays which can then be presented in the buffer for preview

But for now I have no intention to implement this. But if someone is interested, PRs are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant