Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible unused dependency blocking upgrade to python 3.11 #14

Closed
M-C-Sec opened this issue Dec 21, 2022 · 1 comment
Closed

Possible unused dependency blocking upgrade to python 3.11 #14

M-C-Sec opened this issue Dec 21, 2022 · 1 comment

Comments

@M-C-Sec
Copy link

M-C-Sec commented Dec 21, 2022

Description of Issue

I've just been trying to get this twint fork running on python 3.11, but was coming up against issues installing the requirements, as cchardet doesn't have compatibility for 3.11 (see this issue). There's a fork linked in that thread which is compatible with 3.11, but when I went looking through the twint code for any instances of cchardet I couldn't find anything - it doesn't seem to be imported or referenced anywhere other than the requirements.
Unless I'm missing something, it might be worth removing it as a requirement for the sake of onward compatibility (and the nice performance boost from 3.11!).

I've done some basic tests on my own build and had no issues with removing it, although as it's an encoding library and these were only English language tweets it's perhaps worth some testing with other languages too.

Environment Details

Running in a venv with python 3.11, on macOS Monterey 12.6.1

@minamotorin
Copy link
Owner

@M-C-Sec Thanks for your report.

I agree with your opinion and I'll remove cChardet from requirements.
cChardet was added at db08c90 but it seems cChardet has never been imported as you say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants