Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of = private Cvar.t #205

Closed
imeckler opened this issue May 3, 2018 · 1 comment
Closed

Get rid of = private Cvar.t #205

imeckler opened this issue May 3, 2018 · 1 comment

Comments

@imeckler
Copy link
Member

imeckler commented May 3, 2018

definitions like

module Boolean : sig
  type var = private Cvar.t
end

are ultimately I think bad, because the coercion to Cvar.t leaves implicit the mapping between booleans and field elements. It would be better to have a function Boolean.to_zero_one : Boolean.var -> Cvar.t

@imeckler
Copy link
Member Author

imeckler commented Aug 8, 2019

My opinion on this has changed. I now think of a Boolean not as a bool but as a field element which is either 0 or 1.

@imeckler imeckler closed this as completed Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants