Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_last_sample should be function #10

Closed
jeremysanders opened this issue Nov 26, 2020 · 3 comments
Closed

get_last_sample should be function #10

jeremysanders opened this issue Nov 26, 2020 · 3 comments

Comments

@jeremysanders
Copy link

jeremysanders commented Nov 26, 2020

This is a minor issue, as I can work around the difference using get_chain instead.

In emcee, get_last_sample is a function which returns the last sample. In zeus this is a property. For compatibility, it would be useful to match the emcee API. It also doesn't make sense to me to use a property called get_XXX.

PS Thanks for working on this software and algorithm - initial tests are looking good

@minaskar
Copy link
Owner

Hi Jeremy,
Thanks a lot for spotting this!
I'll make sure. it's fixed in the next release.

@minaskar
Copy link
Owner

This is done in version 2.2.2.

@jeremysanders
Copy link
Author

Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants