(Bugfix Issue 137) | Crash in URLSessionClient #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isting serial queue to avoid edge-case crashes - MBApp and BizApp are both experiences some crashes from this issue. - MBApp has had ~300 in the last 30 days - https://fabric.io/mindbody-inc/ios/apps/com.mindbodyonline.connect/issues/7244511901f119bab3c602094384b2c0?time=last-thirty-days
Generated by 🚫 Danger |
eneko
approved these changes
Jul 22, 2019
|
Looks good 👍 but SwiftLint appears to be throwing a false-positive. I'll check it out |
|
Looks like there is an open issue: realm/SwiftLint#2782 We might need to set up a workaround for the time being. I'll open a separate PR to remediate. |
…num_case) (#139) A recent release of SwiftLint includes a new implicit rule, `duplicate_enum_cases`. This rule doesn't consider conditional compilation flags, as described in the open issue here: realm/SwiftLint#2782 For now, I've added an exception to allow builds to proceed.
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
+ Coverage 82.92% 82.92% +<.01%
==========================================
Files 63 63
Lines 2559 2560 +1
==========================================
+ Hits 2122 2123 +1
Misses 437 437
Continue to review full report at Codecov.
|
johnhammerlund
approved these changes
Jul 22, 2019
|
Need to update the CHANGELOG and prep a release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes (pick all that apply):
Summary
Implementation
Moved dictionary indexing for a completion block collection to the an existing serial queue to avoid edge-case crashes
Test Plan
Utilize the framework