Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of all options in streamlined Plot.new function #32

Closed
mindok opened this issue Oct 15, 2020 · 2 comments · Fixed by #34
Closed

Allow setting of all options in streamlined Plot.new function #32

mindok opened this issue Oct 15, 2020 · 2 comments · Fixed by #34

Comments

@mindok
Copy link
Owner

mindok commented Oct 15, 2020

The range of options that can be passed in Plot.new/5 is much more limited than what could be set creating the PlotContent manually. Extent to include at least more common options such as colour scheme.

@srowley
Copy link
Contributor

srowley commented Oct 15, 2020

As I recall you can pass any PlotContent option to Plot.new/5. E.g.,

Plot.new(dataset, BarChart, 300, 200, colour_palette: :pastel1)

@mindok
Copy link
Owner Author

mindok commented Oct 16, 2020

Unfortunately it looks like they get ignored. I have a note in the roadmap to rationalise the option handling. If all the options are held as a keyword list rather than individual values in the struct, this streamlined API approach should be more reliable.

@mindok mindok mentioned this issue Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants