Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transmit_global_variables is broken #39

Closed
donspaulding opened this issue Feb 3, 2016 · 1 comment · Fixed by #41
Closed

transmit_global_variables is broken #39

donspaulding opened this issue Feb 3, 2016 · 1 comment · Fixed by #41

Comments

@donspaulding
Copy link
Contributor

The transmit_global_variables should transmit globals respective to the module of the bottom frame of the traceback (e.g. frame.f_globals much like frame.f_locals is used for local vars). Here's the code in question:

https://github.com/MindscapeHQ/raygun4py/blob/master/python2/raygun4py/raygunmsgs.py#L121

What this does is transmit the globals of the raygunmsgs.py module, which are almost certainly completely unrelated to the actual error being logged, unless I'm missing something?

@fundead
Copy link
Contributor

fundead commented Feb 4, 2016

Thanks for reporting this one, at a review looks like you're correct. I'll investigate this one shortly and look at getting a fix out in the near future.

Regards,

Callum Gavin
Raygun Limited

@donspaulding donspaulding changed the title transmit_global_variables is horribly broken transmit_global_variables is broken Feb 5, 2016
@fundead fundead mentioned this issue Feb 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants