New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wrong time-series alignment and add WA for StatsForcastAutoARIMA #1022
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR :)
The workaround is okay. There are two other modifications that I'm not 100% convinced on yet. I will manually test a bit more, but if you have any proof it would be awesome to translate that into a test
that captures the failing behavior, so that we can catch this next time that the alignment fails. If you can't, then give me some time and I will 1) merge this and 2) add tests on top.
Update: the test in #1023 leads me to believe the general alignment behavior is correct ( |
thanks @paxcema |
For now, can you please remove the changes in offset indexes? Just leave the StatsForecast workaround, and I will merge immediately. We can debug the second problem in a separate PR. Thanks! |
yes we've just left the StatsForcastAutoARIMA wa there and remove other changes |
Can you try to merge again please? Somehow GitHub thinks the newly added |
tried to merge again, not sure is that OK or not |
Yes, merge is now fine 👍 There is a failing test, however. I will have to take a closer look on why before merging. |
Ah, it fails when EDIT: Found a way. I will merge this anyway because it has certainly been very helpful, and I will overwrite on top with another PR. Thanks @bachng2017! |
thanks, the merge also very helpful for us. |
a proposed fix for time-series alignment error and issue of StatsForcastAutoARIMA
the proposed fix is tested with house-sale tutorial only. It might need more review to consider the impact of the change