Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest version does not capture changelog content #63

Closed
classabbyamp opened this issue Jun 27, 2022 · 5 comments
Closed

latest version does not capture changelog content #63

classabbyamp opened this issue Jun 27, 2022 · 5 comments

Comments

@classabbyamp
Copy link

Since the latest update (v2.1.0), the contents of the changelog are not captured and outputted by the action.


workflow affected

workflow run

affected workflow step debug log
##[debug]Evaluating condition for step: 'Get Changelog Content'
##[debug]Evaluating: success()
##[debug]Evaluating success:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Get Changelog Content
##[debug]Loading inputs
##[debug]Evaluating: env.version_num
##[debug]Evaluating Index:
##[debug]..Evaluating env:
##[debug]..=> Object
##[debug]..Evaluating String:
##[debug]..=> 'version_num'
##[debug]=> '1.1.0'
##[debug]Result: '1.1.0'
##[debug]Loading env
Run mindsers/changelog-reader-action@v[2](https://github.com/0x5c/hexchat-void-repos/runs/7059293304?check_suite_focus=true#step:4:2)
::group::Parse data
Parse data
::group::Validate data
Validate data
::set-output name=version::1.1.0
##[debug]steps.changelog_reader.outputs.version='1.1.0'
::set-output name=date::2022-0[6](https://github.com/0x5c/hexchat-void-repos/runs/7059293304?check_suite_focus=true#step:4:6)-26
##[debug]steps.changelog_reader.outputs.date='2022-06-26'
::set-output name=status::released
##[debug]steps.changelog_reader.outputs.status='released'
::set-output name=changes::
##[debug]steps.changelog_reader.outputs.changes=''
##[debug]Node Action run completed with exit code 0
##[debug]Finishing: Get Changelog Content
@0x5c
Copy link

0x5c commented Jun 27, 2022

That seems unlikely to me, considering there is no errors even in the debug log

@nathany-copia
Copy link
Contributor

nathany-copia commented Jun 30, 2022

Also ran into an issue where the changelog changes is no longer being placed in the release (as of a few weeks ago). This is across two projects and was working before. That said, I'm not sure if the issue is with changelog-reader-action or with ncipollo/release-action.

I did compare our YML config to what's in the readme here, and it still looks the same. Note: I have the validation engine in the default disabled state:

- name: Read changelog
  id: changelog_reader
  uses: mindsers/changelog-reader-action@v2
  with:
    version: ${{ steps.tag_name.outputs.current_version }}
    path: ./CHANGELOG.md

@nathany-copia
Copy link
Contributor

I can confirm that specifying uses: mindsers/changelog-reader-action@v2.0.0 works.

@classabbyamp
Copy link
Author

not sure if the issue is with changelog-reader-action or with ncipollo/release-action.

based on the debug output in my instance, it's definitely changelog-reader, because it shows that the output is an empty string. I also don't use that release action

@mindsers
Copy link
Owner

mindsers commented Jul 3, 2022

Hi! Thanks for the report. We're working on it. The exact issue should be fixed by #62

@mindsers mindsers closed this as completed Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants