Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid unnecessary git checks #339

Merged
merged 5 commits into from May 11, 2022
Merged

fix: avoid unnecessary git checks #339

merged 5 commits into from May 11, 2022

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented May 5, 2022

Now the git checks only happen in run and with --changed flag.

@i4ki i4ki requested a review from katcipis May 5, 2022 19:20
@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #339 (cd5b435) into main (6591957) will decrease coverage by 0.49%.
The diff coverage is 30.18%.

@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   68.23%   67.73%   -0.50%     
==========================================
  Files          36       36              
  Lines        6670     6670              
==========================================
- Hits         4551     4518      -33     
- Misses       1859     1902      +43     
+ Partials      260      250      -10     
Flag Coverage Δ
tests 67.73% <30.18%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/terramate/cli/cli.go 5.81% <2.32%> (-0.05%) ⬇️
cmd/terramate/cli/project.go 44.18% <46.29%> (-17.52%) ⬇️
git/git.go 74.16% <50.00%> (-0.25%) ⬇️
test/sandbox/git.go 74.82% <100.00%> (+0.53%) ⬆️
manager.go 63.10% <0.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6591957...cd5b435. Read the comment docs.

katcipis
katcipis previously approved these changes May 6, 2022
Copy link
Contributor

@katcipis katcipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for improving the changes and the tests 💯

cmd/terramate/cli/cli.go Outdated Show resolved Hide resolved
cmd/terramate/e2etests/general_test.go Show resolved Hide resolved
i4ki and others added 3 commits May 11, 2022 11:09
Co-authored-by: Tiago Cesar Katcipis <tiagokatcipis@gmail.com>
@katcipis katcipis merged commit c9a486b into main May 11, 2022
@katcipis katcipis deleted the i4k-avoid-git-in-generate branch May 11, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants