Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disable-check-git-remote #346

Merged
merged 7 commits into from May 16, 2022
Merged

Conversation

katcipis
Copy link
Contributor

This PR also fixes terramate run so it always checks if the local default branch is updated with remote (even without --changed). Given that terramate run always checks if the remote is updated, for scenarios where that is not wanted we introduce --disable-check-git-remote. So in a scenario where terramate run is failing on the git check running terramate run --disable-check-git-remote will work.

@katcipis katcipis requested a review from i4ki May 11, 2022 15:30
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #346 (881304c) into main (cd89f43) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
+ Coverage   67.79%   67.80%   +0.01%     
==========================================
  Files          36       36              
  Lines        6683     6682       -1     
==========================================
  Hits         4531     4531              
+ Misses       1902     1901       -1     
  Partials      250      250              
Flag Coverage Δ
tests 67.80% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/terramate/cli/cli.go 5.81% <0.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd89f43...881304c. Read the comment docs.

i4ki
i4ki previously approved these changes May 16, 2022
Copy link
Contributor

@i4ki i4ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cmd/terramate/e2etests/general_test.go Outdated Show resolved Hide resolved
}

func TestRunWithoutGitRemoteCheckWorksWithoutNetworking(t *testing.T) {
// Regression test to guarantee that all git checks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Co-authored-by: Tiago de Bem Natel de Moura <t.nateldemoura@gmail.com>
@katcipis katcipis merged commit c71cf34 into main May 16, 2022
@katcipis katcipis deleted the katcipis-git-disable-check-remote branch May 16, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants