Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stack block with unrecognized blocks #358

Merged
merged 16 commits into from May 30, 2022
Merged

fix: stack block with unrecognized blocks #358

merged 16 commits into from May 30, 2022

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented May 25, 2022

Reason for This Change

The parser was not failing for configurations containing a stack block with unrecognized child blocks.

Description of Changes

Makes the parser returns errors for each unrecognized block.

@i4ki i4ki requested a review from katcipis May 25, 2022 13:30
@i4ki
Copy link
Contributor Author

i4ki commented May 25, 2022

@katcipis
I got this while testing the extension, it's actually a bug in main but let's merge after the #357 PR is merged so we have this in the changelog of fixes.

katcipis
katcipis previously approved these changes May 25, 2022
Base automatically changed from i4k-add-multiple-errs to main May 30, 2022 08:39
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #358 (e1d6391) into main (07c9a37) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
+ Coverage   68.02%   68.04%   +0.01%     
==========================================
  Files          37       37              
  Lines        6947     6953       +6     
==========================================
+ Hits         4726     4731       +5     
- Misses       1967     1968       +1     
  Partials      254      254              
Flag Coverage Δ
tests 68.04% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
hcl/hcl.go 87.55% <100.00%> (+0.08%) ⬆️
manager.go 62.86% <0.00%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07c9a37...e1d6391. Read the comment docs.

@i4ki i4ki requested a review from katcipis May 30, 2022 08:46
@i4ki i4ki merged commit 3f4b4a3 into main May 30, 2022
@i4ki i4ki deleted the i4k-fix-stack-parser branch May 30, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants