Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: terramate.config.git block with unrecognized blocks #359

Merged
merged 20 commits into from May 30, 2022
Merged

Conversation

i4ki
Copy link
Contributor

@i4ki i4ki commented May 25, 2022

Fix the parser not returning errors if the terramate.config.git had unrecognized blocks.

@i4ki i4ki changed the base branch from main to i4k-add-multiple-errs May 25, 2022 14:29
@i4ki i4ki changed the base branch from i4k-add-multiple-errs to i4k-fix-stack-parser May 25, 2022 14:29
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #359 (26e8018) into main (3f4b4a3) will increase coverage by 0.03%.
The diff coverage is 81.97%.

❗ Current head 26e8018 differs from pull request most recent head 7e8db2d. Consider uploading reports for the commit 7e8db2d to get more accurate results

@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
+ Coverage   68.05%   68.09%   +0.03%     
==========================================
  Files          37       37              
  Lines        6953     6952       -1     
==========================================
+ Hits         4732     4734       +2     
+ Misses       1967     1964       -3     
  Partials      254      254              
Flag Coverage Δ
tests 68.09% <81.97%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
errors/list.go 89.33% <80.00%> (-3.08%) ⬇️
hcl/hcl.go 87.61% <81.40%> (+0.05%) ⬆️
errors/error.go 95.55% <85.18%> (+2.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f4b4a3...7e8db2d. Read the comment docs.

@i4ki i4ki requested a review from katcipis May 25, 2022 14:36
@i4ki i4ki changed the title fix: unrecognized terramate.config.git blocks fix: terramate.config.git block with unrecognized blocks May 25, 2022
katcipis
katcipis previously approved these changes May 25, 2022
Copy link
Contributor

@katcipis katcipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice 🚀

Base automatically changed from i4k-fix-stack-parser to main May 30, 2022 08:57
@i4ki i4ki merged commit 0d41f4a into main May 30, 2022
@i4ki i4ki deleted the i4k-fix-git-parser branch May 30, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants