-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect globals conflict handling #745
Conversation
Codecov ReportBase: 72.02% // Head: 72.07% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
==========================================
+ Coverage 72.02% 72.07% +0.04%
==========================================
Files 73 73
Lines 12116 12127 +11
==========================================
+ Hits 8727 8740 +13
+ Misses 3050 3049 -1
+ Partials 339 338 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀
Reason for This Change
The fix #738 introduced a bug in the globals conflict checks.
It can be reproduced with the configuration below:
When running Terramate it gives the error below:
The reason is that when fixing #738 we switched to store the "config dir" in the eval.Object values because it was needed to solve the problem but the check for conflicting attributes (at runtime) needs the actual source file (not from where it's being imported).
Description of Changes
The fix just stores both the configuration dir and the origin source path in the eval.Object.