Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow colorizing chat messages on selected channels #32

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

S-S-X
Copy link
Member

@S-S-X S-S-X commented Apr 6, 2021

Also fix on_send_on_channel callbacks through message.lua, was canceling all upcoming callbacks on success.

To allow sending (#f00)Hello red world! (#0f0)And green too! on channel there's configuration option to enable colorize on channels:

beerchat.colorize_channels = fun, pvp

Accepts comma or space separated list of channels.

@S-S-X S-S-X added the enhancement New feature or request label Apr 6, 2021
BuckarooBanzay added a commit to pandorabox-io/pandorabox.io that referenced this pull request Apr 6, 2021
@BuckarooBanzay
Copy link
Member

didn't test it but LGTM, now should we bridge that to discord/irc too so the noise will shift to that channel? 🤔

@S-S-X
Copy link
Member Author

S-S-X commented Apr 6, 2021

didn't test it but LGTM, now should we bridge that to discord/irc too so the noise will shift to that channel? 🤔

I think that's not really needed yet, most Discord and IRC users are not that interested. Then Discord and IRC probably wont handle those color codes that well.
Maybe return to that later if channels gains more traction through addition fun features and becomes more active?

So far it has been more like forcing players who announce all their feelings, ores found, deaths, bunnies and monsters seen at #main.

With this change I hope that these players find some special reason to announce that stuff at #fun, generally chat there and possibly also invite others there instead of attempting to move that chat style back to #main every now and then.

This was referenced Apr 6, 2021
@S-S-X S-S-X merged commit 560311a into master Apr 6, 2021
@S-S-X S-S-X deleted the colorful-channels branch April 7, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants