Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player model is incorrect #74

Closed
IrrlichtMt4 opened this issue Apr 26, 2022 · 14 comments
Closed

Player model is incorrect #74

IrrlichtMt4 opened this issue Apr 26, 2022 · 14 comments
Labels
bug Something isn't working

Comments

@IrrlichtMt4
Copy link

IrrlichtMt4 commented Apr 26, 2022

The player model is incorrect the body, legs and arms have rectangular pixels instead of square pixels.

@BuckarooBanzay BuckarooBanzay added the bug Something isn't working label Apr 26, 2022
@IrrlichtMt4
Copy link
Author

This is a comparison between the incorrect model and the correct model.

screenshot_20220527_184500

This is the correct model:
screenshot_20220527_184947

@IrrlichtMt4
Copy link
Author

Compare the player model with player_api from mtg and the player model from 3d_armor for more info.

@SmallJoker
Copy link
Member

3d_armor's model must be different to take the armor textures into account. Please propose a corrected model instead. I have no idea how to correct this.

@IrrlichtMt4
Copy link
Author

Maybe 3d_armor's model could be taken from minetest_game's model and could the extra layer for the armor textures could be added. Sorry, I can't model this in Blender (I'm new to it and I would probably mess a lot of things).

@IrrlichtMt4
Copy link
Author

An issue in minetest_game exists that could help with modeling at minetest/minetest_game#1411

@IrrlichtMt4
Copy link
Author

Another solution is to shrink the visuals of the body, arms, and legs while keeping the armor size the same.

@IrrlichtMt4
Copy link
Author

IrrlichtMt4 commented Jul 1, 2022

Another solution is to shrink the visuals of the body, arms, and legs while keeping the armor size the same. Similar to visible_sneak mod

@IrrlichtMt4
Copy link
Author

IrrlichtMt4 commented Jul 1, 2022

Another solution is to make the mod look for the already existing model for the player and add the extra layer of armor. Similar to simple_skins when attaching the cape.

@IrrlichtMt4
Copy link
Author

IrrlichtMt4 commented Sep 10, 2022

@BuckarooBanzay
Copy link
Member

Hello, any comments?

👇

Please propose a corrected model instead

@IrrlichtMt4
Copy link
Author

Ok got a model (not mine I don't know how to model in Blender so I am giving minetest_game model https://github.com/minetest/minetest_game/tree/master/mods/player_api/models/character.blend .

@BuckarooBanzay
Copy link
Member

Ok got a model (not mine I don't know how to model in Blender so I am giving minetest_game model

Yeah, that wont work: the minetest_game model doesn't have the shield and armor parts :/

3d armor model

Screenshot_2022-09-16_10-55-17

minetest_game model

Screenshot_2022-09-16_10-55-50

@IrrlichtMt4
Copy link
Author

Since I can't model the extra armor parts for the player I'm closing this issue. When I can model I will send a model :)

@IrrlichtMt4
Copy link
Author

How about instead of changing the blender model, we can use a method similar to the visible_sneak mod. Visible sneak makes the player seem slightly squashed when the player sneaks. I think we should use the visible sneak_sneak but not squash the player as much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants