Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treasures #50

Merged
merged 6 commits into from Nov 27, 2021
Merged

Treasures #50

merged 6 commits into from Nov 27, 2021

Conversation

Treer
Copy link
Collaborator

@Treer Treer commented Sep 18, 2021

Adds:

  • Nether staff of Light
  • Nether staff of Eternal Light
  • Gives the Nether pickaxe a 10x bonus reduction on wear when mining netherrack (and is fast for netherrack)
  • Netherrack slabs and walls
  • Netherbrick stairs, slabs, inner stairs and outer stairs

These changes are building toward adding some kind of Nether Citadel structures, but progress on that will be slow (if it even gets finished at all) so may as well get feedback on these.

New nodes

Slabs, stairs and walls will be rather helpful for a structure, but I like to keep nodes to an absolute minimum so I'm in a bind and this adds a few to provide some building basics and bring netherrack and deep netherrack recipes in line with each other:

  • Both netherracks: wall*, stairs, and slabs
  • Both netherbricks: stairs, slabs, inner-stairs and outer-stairs

*walls are an optional-dependency on the walls mod (in MTG)

I think it's 9 new nodes, since many of these already existed.

Treasures

It would be nice to have treasure items that can only be obtained from the nether

Nether pickaxe

@lortas might be interested in the change to the Nether pickaxe.
Netherrack is hard to dig, and the nether pickaxe is already suitably hard to obtain, so I've weakened it a little against other nodes and made it able to mine 350 netherrack nodes before wearing out (instead of 35). Getting one might now be a priority for anyone wanting to build in the nether, and it could be a treasure item, but tool balancing is not my forte.

(It would also be possible to give the Nether pickaxe the ability to "silktouch" mine the Lava Crust nodes)

Staff of Light

I made a quick video of this because it's pretty cool, and I don't expect people to install a pull request to see it:

Watch the video

These combine / are inspired by @FaceDeer's torch crossbow and @Xanthin's Staff of Light (@-mentioned in case they wish to yoink anything from here back into theirs)

The staffs come in two flavors:
The Nether staff of Eternal Light has 60 shots and turns netherrack into glowstone, but the fun one is the one that lets you go wild with unlimited shots, with your "damage" to the nether being reverted 40 seconds later.

The staffs don't currently have recipes as I expect they will only be obtainable from dungeon chests or citadels etc.

  • Is 2 new 12kb sounds for a rare item too much? This PR omits one of the sounds and reuses the portal ignition sound instead, but the sound used in the video is better.
  • untested with server lag (is there a way to simulate that?)

@SmallJoker
Copy link
Member

untested with server lag (is there a way to simulate that?)

Maybe this can help you: https://www.linuxpoweruser.com/?p=41
Otherwise try to set the server step to >1 second and tick the "Host server" checkbox to use this setting.

Is 2 new 12kb sounds for a rare item too much?

No, I think this is totally fine.

Concept-wise this seems fine 👍

@lortas
Copy link
Contributor

lortas commented Nov 7, 2021

Interesting modification on the Nether pickaxe. My initial thought was that a tool made of very tough material, is very solid, but your interpretation is okay for me.
You also may find my recently pull request interesting: minetest-mods/3d_armor#65

Treer and others added 6 commits November 27, 2021 15:21
Also adds deep netherrack stairs, and deep nether brick stairs, slabs, inner stairs and outer stairs.
Adds 9 new nodes in total.
…rrack

cracky-3 mining time of Nether pickaxe reduced from 0.4 to 0.3 to mine netherrack faster.
maxlevel of nether pickaxe dropped from 3 to 2 to increase wear damage with non-netherrack nodes.
Adds "Nether staff of Light" and "Nether staff of Eternal Light"
One is limited to 60 uses, and the other has unlimited uses but the glowstone it creates will only last for 40 seconds.
There are no crafting recipes as I hope these to eventually be treasure that can be found in the nether.
(It sounds better than reusing the portal ignition sound)
@Treer Treer merged commit d8e6a6a into minetest-mods:master Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants