This repository has been archived by the owner on May 13, 2024. It is now read-only.
[SDL] Improve handling of IMEs #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
suggested changes
Feb 7, 2024
appgurueu
approved these changes
Feb 7, 2024
|
Actually I think I can fix another (semi-related) bug while I am at it. Edit: done. |
y5nw
changed the title
appgurueu
reviewed
Feb 7, 2024
sfan5
reviewed
Feb 8, 2024
sfan5
approved these changes
Feb 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the text input rectangle when text input is used. It allows (among other things) IMEs to position the text input candidate list correctly.
The screenshots below demonstrate the difference. In both screenshots, the "World name" input box is focused.
Before:
After:
This also (at least partially) fixes minetest/minetest#13473 (dead keys and compose keys do seem to work under IBus for me now) by not restarting text input when this is not necessary.