Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Celery #68

Closed
gabriel-tessier opened this issue Mar 16, 2020 · 5 comments
Closed

Adding Celery #68

gabriel-tessier opened this issue Mar 16, 2020 · 5 comments
Labels
kind/feat/icon Icon request

Comments

@gabriel-tessier
Copy link
Contributor

gabriel-tessier commented Mar 16, 2020

Hi,

I needed celery (http://www.celeryproject.org/) icon for a diagrams and I add it in my fork: https://github.com/gabriel-tessier/diagrams

I wonder If I can make a PR for this as nobody so far asked for celery.
Is there rule about adding a new resource or we can add any ressource and push a PR?

Maybe some lines in the contribution guide can help.

Thanks again for this great software!

@thedrow
Copy link

thedrow commented Mar 30, 2020

Celery maintainer here. I'd really like this issue to be resolved.
What can I do to help?

@djalexd
Copy link

djalexd commented Mar 30, 2020

Hi,

I've extended the library locally by including some classes and icons.

It's as easy as providing them similarly to other classes. For example:
https://github.com/mingrammer/diagrams/blob/master/diagrams/k8s/__init__.py
https://github.com/mingrammer/diagrams/tree/master/resources/k8s/compute

@gabriel-tessier
Copy link
Contributor Author

I'll push a PR with the celery icon, today (UTC +9).

@mingrammer
Copy link
Owner

mingrammer commented Mar 31, 2020

You can add it to onprem.queue category: https://diagrams.mingrammer.com/docs/nodes/onprem#onpremqueue

And please follow this guide: https://github.com/mingrammer/diagrams/blob/master/CONTRIBUTING.md

@mingrammer mingrammer added the kind/feat/icon Icon request label Mar 31, 2020
mingrammer added a commit that referenced this issue Mar 31, 2020
@gabriel-tessier
Copy link
Contributor Author

@thedrow
Thanks for +1 this issue and for Celery, the PR was merged.

@mingrammer
Thank you for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feat/icon Icon request
Projects
None yet
Development

No branches or pull requests

4 participants