Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong GitHub profile link #2

Closed
McPringle opened this issue Jan 27, 2022 · 2 comments
Closed

Wrong GitHub profile link #2

McPringle opened this issue Jan 27, 2022 · 2 comments

Comments

@McPringle
Copy link
Contributor

After using your action (thank you very much for automating this task), the profile links in the CONTRIBUTORS.md are broken. They point to an API call instead of the profile page:

Actual: https://api.github.com/users/McPringle
Expected: https://github.com/McPringle

As a result, if the viewer of the file clicks on the GitHub username, he will get a JSON file instead of the expected profile page.

@McPringle
Copy link
Contributor Author

I found the problem! I copied your example from the readme file which was using v3. After changing it manually to v3.1 the links are correct!

@Lewiscowles1986
Copy link

Still not 💯 what a user might expect. Perhaps scan the URI and nope out to prevent confusion; or just build the URI to the user profile...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants