Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images resizing when appearing via include #54

Open
ansleyerickson opened this issue Feb 20, 2024 · 1 comment
Open

images resizing when appearing via include #54

ansleyerickson opened this issue Feb 20, 2024 · 1 comment

Comments

@ansleyerickson
Copy link

Images are appearing in correct proportion in the item's page
(ex. https://harlemeducationhistoryproject.github.io/wadleigh/exh/wad001.html)
but appear with altered proportions when included on another page (ex. https://harlemeducationhistoryproject.github.io/wadleigh/).

  • happening in Chrome, not Safari (desktop or mobile)
@amzoss
Copy link
Collaborator

amzoss commented Feb 20, 2024

The item page is using the generic collection item layout to set up the image viewer, which uses the simple_image_viewer include. On your index or home page, you're using the inline image include. These two includes have different HTML for displaying images. If you want the home page to look like the item page, you could try using the image viewer include on the home page, or you could create a modified version of it to use on the homepage if it needs some changes to work on that page.

(On my machine, it looks like both includes are working as intended. The image on the home page doesn't look distorted to me, just a different size from the item page, and with an added colored border for the caption, and aligned to the left instead of the center.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants