Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image metadata output different for iiif vs simple #93

Closed
leucotic opened this issue Oct 19, 2020 · 3 comments
Closed

image metadata output different for iiif vs simple #93

leucotic opened this issue Oct 19, 2020 · 3 comments

Comments

@leucotic
Copy link

leucotic commented Oct 19, 2020

The Simple image derivative script seems to output a different image metadata path than the IIIF script to the csv and other files, which breaks the search thumbnail preview.

IIIF:
"/img/derivatives/iiif/images/obj4/full/250,/0/default.jpg",/img/derivatives/iiif/obj4/manifest.json,"/img/derivatives/iiif/images/obj4/full/1140,/0/default.jpg"

Simple:
img/derivatives/simple/obj11/thumbnail.jpg,img/derivatives/simple/obj11/fullwidth.jpg

the IIIF script puts a / in front of img. (It also includes quotations, which I'm not sure make a huge difference). The Simple script breaks the thumbnail display in the search page because it's missing that / and the path ends up running together like localhost:4000/waximg/derivatives/... instead of localhost:4000/wax/img/derivatives/...

The thumbnail images don't show up on the search page and jekyll gives this error (showing the path name run-in without the /):
ERROR '/waximg/derivatives/simple/obj11/thumbnail.jpg' not found.

I was able to manually fix the thumbnail error by adding slashes to all the thumbnail pathways in the search/index.json, but it would be extremely annoying to do if I had a lot more images. Both the scripts should output the same path format.

@leucotic leucotic changed the title image directories output different for iiif vs simple image metadata output different for iiif vs simple Oct 19, 2020
@leucotic leucotic reopened this Oct 19, 2020
@mnyrop
Copy link
Member

mnyrop commented Oct 19, 2020

@leucotic you 100% caught a bug, thanks for the heads up!
if you need a less tedious fix while I work on a patch in the wax_tasks gem, you can temporarily fix this in your site by adding a slash between ${url} and ${item.thumbnail} in assets/search-ui.js:

https://github.com/minicomp/wax/blob/main/assets/search-ui.js#L14

(I'll leave this issue open until I release the patch.)

@mnyrop mnyrop added the bug label Oct 19, 2020
@mnyrop mnyrop self-assigned this Oct 19, 2020
@leucotic
Copy link
Author

Thank you! I will try that.
(I'm just learning the framework for now and gathering materials for a collection, I don't have a live site yet, but I will soon, hopefully!)

@mnyrop
Copy link
Member

mnyrop commented Jun 17, 2021

This has been fixed in wax_tasks#74 and released on rubygems.org.
bundle update wax_tasks will pull in the newest version 1.1.5

@mnyrop mnyrop closed this as completed Jun 17, 2021
1.1.x – Pre-Dream Lab Sprint 🧪 automation moved this from To do to Done Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants