Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] modifying feed image urls #658

Closed
vosian opened this issue May 8, 2020 · 4 comments
Closed

[Question] modifying feed image urls #658

vosian opened this issue May 8, 2020 · 4 comments

Comments

@vosian
Copy link

vosian commented May 8, 2020

Hello, I'd like to modify the image urls in the feeds themselves, I just want to run them through a compression service, what I want to do just requires adding a string before and after the image url which hopefully isn't too hard to do. But I don't know where I should look in the code to try and get this changed so I'd be thankful for some guidance.

@ghost
Copy link

ghost commented May 8, 2020

If you are always using the image proxy you could simply change imageURL in ui/proxy.go:41. Otherwise template/functions.go:67 aswell.

This does not modify the entries stored in the database but only their representation on the website. Is this what you want?

@vosian
Copy link
Author

vosian commented May 9, 2020

As I never programmed in go, I went with the first option as it seemed simpler, it's hard to know if the proxy is beign applied due tot he link obfuscation miniflux does, however, I think it's working due to the quality loss. Now I need to test if programs that use miniflux as a backend use the proxy or directly go with the database information.

@ghost
Copy link

ghost commented May 9, 2020

By default the image proxy is only being applied to http images (without SSL), that's the "obfuscation" you see (it's just the base64 of the image url). If you want to always use the image proxy, run with the PROXY_IMAGES=all environment variable. See https://miniflux.app/docs/configuration.html

@vosian
Copy link
Author

vosian commented May 9, 2020

Thank you, although it seems that programs that use miniflux as backend work directly with the database, which shouldn't be surprising I guess, but I now I need to find if there's some way to modify the database, I'm guessing this would have to be done at the steps where feeds are parsed and might not be straightforward.

@miniflux miniflux locked and limited conversation to collaborators Mar 27, 2023
@fguillot fguillot converted this issue into discussion #1779 Mar 27, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Development

No branches or pull requests

2 participants