Adds keyboard shortcut for refreshing all feeds #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Binds the 'R' key to trigger a refresh in the background for all feeds. - Updates the locale, using the same description as the link in the feeds page.
pellegrino
force-pushed
the
keyboard-refresh-all
branch
from
c6e8b61
to
340dde8
Compare
fguillot
reviewed
May 25, 2020
ui/static/js/app.js
Outdated
| @@ -167,11 +167,24 @@ function markEntryAsRead(element) { | |||
| } | |||
| } | |||
|
|
|||
| // Send the Ajax request to refresh all feeds in the background | |||
| function handleRefreshAllFeeds() { | |||
| let url = "/feeds/refresh"; | |||
There was a problem hiding this comment.
Hardcoding the URL should be avoided because some people are running Miniflux within a subfolder. You could do the same thing as the function below:
let url = document.body.dataset.refreshAllFeedsUrl;
And let the router generate the URL by updating the body element in layout.html.
pellegrino
force-pushed
the
keyboard-refresh-all
branch
from
812a1d7
to
340dde8
Compare
This change lets the router generate the refresh all feeds endpoint url, instead of hardcoding the URL.
|
Thanks for your pointers! It helped me to navigate the code. I did the changes you mentioned! Any further improvements you would like to see? Cheers! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a feature that I'm using on my personal deployment.
feeds.
feeds page.