Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #13 #17

Merged
merged 2 commits into from Apr 5, 2019
Merged

fix #13 #17

merged 2 commits into from Apr 5, 2019

Conversation

evan-burke
Copy link
Contributor

This initial commit enables automl-gs to work on win10. I can test on win8 and linux, but don't have access to a Mac to make sure everything still works normally there.

@adamio
Copy link

adamio commented Apr 3, 2019

Works on Win 8.1

@evan-burke
Copy link
Contributor Author

Worked fine for me on Ubuntu 18 as an imported module. I have a hard time imagining this would break on Mac OS, but worst case we can just add a condition like this:

if 'win' in sys.platform:
    # Find the python executable
    ... 

@minimaxir
Copy link
Owner

minimaxir commented Apr 4, 2019

Will take a look tonight and merge / release a v0.2.1 ASAP if good

@minimaxir minimaxir merged commit aba6dbf into minimaxir:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants