You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a follow up issue of refactor task from this comment #1997 (comment).
We have many pre-flight files now inside cmd/minishift/cmd folder.
We can create one folder preflight and store all the existing (or future) files in it to have better separation.
Note: This will also help in readability when we will use in start.go as preflight.preflightChecksBeforeStartingHost.
May be now function name should be renamed to checksBeforeStartingHost as preflight word is not needed once we have its package.
The text was updated successfully, but these errors were encountered:
preflight.preflightChecksBeforeStartingHost should be something like preStartingHost and we need a postStartingHost generic call... as we can also implement this also in Minikube.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This is a follow up issue of refactor task from this comment #1997 (comment).
We have many pre-flight files now inside
cmd/minishift/cmd
folder.We can create one folder
preflight
and store all the existing (or future) files in it to have better separation.Note: This will also help in readability when we will use in
start.go
aspreflight.preflightChecksBeforeStartingHost
.May be now function name should be renamed to
checksBeforeStartingHost
aspreflight
word is not needed once we have its package.The text was updated successfully, but these errors were encountered: