Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get all pre-flight files into separate folder #2065

Open
coolbrg opened this issue Feb 23, 2018 · 2 comments
Open

Get all pre-flight files into separate folder #2065

coolbrg opened this issue Feb 23, 2018 · 2 comments

Comments

@coolbrg
Copy link
Contributor

coolbrg commented Feb 23, 2018

This is a follow up issue of refactor task from this comment #1997 (comment).

We have many pre-flight files now inside cmd/minishift/cmd folder.
We can create one folder preflight and store all the existing (or future) files in it to have better separation.

Note: This will also help in readability when we will use in start.go as preflight.preflightChecksBeforeStartingHost.
May be now function name should be renamed to checksBeforeStartingHost as preflight word is not needed once we have its package.

@gbraad
Copy link
Member

gbraad commented Feb 26, 2018

preflight.preflightChecksBeforeStartingHost should be something like preStartingHost and we need a postStartingHost generic call... as we can also implement this also in Minikube.

@stale
Copy link

stale bot commented Apr 27, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants