Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve seperation of cmd and pkg for host folder actions #2129

Open
hferentschik opened this issue Mar 14, 2018 · 2 comments
Open

Improve seperation of cmd and pkg for host folder actions #2129

hferentschik opened this issue Mar 14, 2018 · 2 comments

Comments

@hferentschik
Copy link
Member

hferentschik commented Mar 14, 2018

pkg/minishift/hostfolder/cifs_hostfolder.go still does a lot of writing to the console, like fmt.Println("OK") or fmt.Println("FAIL"). This should really happen in the cmd part of the source tree.

One can try to further separate it or if not possible to cleanly separate a Writer should be passed along, and the messages should be written to the writer. This allows to discard messages or write to stdout, etc

@gbraad
Copy link
Member

gbraad commented Mar 16, 2018

pkg should ideally return bool, error states. Rather do not see a Writer being used... unless we have several messages to capture. But likely bubbling an error up would be sufficient enough.

@stale
Copy link

stale bot commented May 15, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants