You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
pkg/minishift/hostfolder/cifs_hostfolder.go still does a lot of writing to the console, like fmt.Println("OK") or fmt.Println("FAIL"). This should really happen in the cmd part of the source tree.
One can try to further separate it or if not possible to cleanly separate a Writer should be passed along, and the messages should be written to the writer. This allows to discard messages or write to stdout, etc
The text was updated successfully, but these errors were encountered:
pkg should ideally return bool, error states. Rather do not see a Writer being used... unless we have several messages to capture. But likely bubbling an error up would be sufficient enough.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
pkg/minishift/hostfolder/cifs_hostfolder.go
still does a lot of writing to the console, likefmt.Println("OK")
orfmt.Println("FAIL")
. This should really happen in the cmd part of the source tree.One can try to further separate it or if not possible to cleanly separate a
Writer
should be passed along, and the messages should be written to the writer. This allows to discard messages or write to stdout, etcThe text was updated successfully, but these errors were encountered: