Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to install and list all the community add-ons #2137

Open
coolbrg opened this issue Mar 15, 2018 · 6 comments
Open

Allow to install and list all the community add-ons #2137

coolbrg opened this issue Mar 15, 2018 · 6 comments

Comments

@coolbrg
Copy link
Contributor

coolbrg commented Mar 15, 2018

@cmoulliard asked me

Is there a trick to download/install an addon which is not there locally but present in minishift-addons repo e.g ansible-service-broker ?

and at present, we don't have such mechanism.
A similar issue we have #635 which is to install addon from the remote location.

My idea here is, for above usecase, we can

  • List community addons with minishift addons list --community ( suggest for different flag )
  • Install community addon as minishift addons install --community ansible-service-broker

This should download the specied add-on directory from the minishift-addon repo and place into the require location.

WDYT @minishift/minishift-dev ?

@cmoulliard
Copy link

--community

I like the idea to install community addons but then we should know from where they are coming from and have also the possibility to install addons released/tagged

minishift addons install --repo https://.... --name community

and for the tagged addons

minishift addons install --repo https://.... --name community --version 3.7

if, by default, the project is cloned from master or another branch, we need also a way to update it
and the commit id should be listed when we list addons info

minishift addons update --community

@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Mar 16, 2018

List community addons with minishift addons list --community ( suggest for different flag )
Install community addon as minishift addons install --community ansible-service-broker

-1 for using community keyword here. When we are talking about an upstream project, everything in the project means community.

We can provide a way to list the catalogue and as @cmoulliard said a way to update the add-ons. But at this point it is not a priority.

@stale
Copy link

stale bot commented May 15, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@anjannath
Copy link
Member

Adding functionality to list community add-ons would be an overkill IMO, then we need to decide which github repos containing add-ons we would fetch the add-ons list from.. which should be configurable by the user.

Remote install which is #635 can be implemented and would be nice feature. But right now the add-ons in the repo are directories, we need to package them in tar balls which can be downloaded, and then we extract it and do the regular add-on install.

@agajdosi
Copy link

@budhram Big 👍 for the ability to list, install and update the addons from the community repository. It would also help the users to have more up-to-date addons.

Last but not least this feature would lower the pressure to release CDK with all addons up-to-date, if there is a bad timing of CDK and eap-cd/xpaas/che releases it would not be big problem no longer. We could just update the repository and users can easily update the addons. WDYT? @LalatenduMohanty

@coolbrg
Copy link
Contributor Author

coolbrg commented Aug 13, 2018

The another aspect is if we allow this then we might need to keep our community add-ons update to date and workable all the time else if user try to install/apply community add-on and found that it is not working it is likely that he would create issues.
Now, we need to decide whether we would consider this aspect and implement this feature and let the issues come in or not implement this feature and be lenient to ourself 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants