Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"minishift openshift restart" right after "minishift start" make router and docker registry unusable #2169

Open
agajdosi opened this issue Mar 23, 2018 · 5 comments

Comments

@agajdosi
Copy link

agajdosi commented Mar 23, 2018

General information

  • Minishift version: current master
  • OS: Linux - CentOS (on centos-ci)
  • Hypervisor: KVM

Steps to reproduce

  1. minishift start
  2. minishift openshift restart
  3. eval $(minishift oc-env)
  4. oc get pods -n default

Expected

Pods docker-registry and router should be running.

Actual

On some system right after the minishift start the docker-registry and router pods' status is Running, however they are not READY:

NAME                            READY     STATUS    RESTARTS   AGE       IP               NODE
docker-registry-1-4np67         0/1       Running   0          15s       172.17.0.5       localhost
docker-registry-1-deploy        1/1       Running   0          21s       172.17.0.4       localhost
persistent-volume-setup-ndlx2   1/1       Running   0          22s       172.17.0.3       localhost
router-1-c9fmh                  0/1       Running   0          15s       192.168.122.40   localhost
router-1-deploy                 1/1       Running   0          21s       172.17.0.2       localhost

When OpenShift container is restarted in this situation the docker-registry and router containers can't handle it and fails. The failure is however quiet and thus will cause problems later.

Fix?

Docker-registry and router pods should be in Running state and READY after startup. Minishift should check this as part of Minishift start.

Also shouldn't we first prepare the local host node for shutdown, restart and then mark the node ready for deployments? (https://docs.openshift.com/container-platform/3.3/admin_guide/manage_nodes.html#rebooting-nodes)

oc adm drain localhost
restart origin container (minishift openshift restart)
oc adm uncordon localhost
wait until registry and router are ready
@agajdosi agajdosi changed the title minishift openshift restart can break router and Docker registry minishift openshift restart can break router and Docker registry pods Mar 23, 2018
@anjannath anjannath self-assigned this Mar 25, 2018
@stale
Copy link

stale bot commented May 24, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/stale label May 24, 2018
@anjannath
Copy link
Member

anjannath commented May 25, 2018 via email

@stale stale bot removed the status/stale label May 25, 2018
@agajdosi agajdosi changed the title minishift openshift restart can break router and Docker registry pods M openshift restart right after M start can break router and Docker registry pods May 30, 2018
@LalatenduMohanty LalatenduMohanty added this to the v1.19.0 milestone May 30, 2018
@LalatenduMohanty
Copy link
Member

Docker-registry and router pods should be in Running state and READY after startup

@agajdosi How to check if the pods are ready? I guess what you are saying is that "running" state of these containers are enough to say these are ready, right?

@agajdosi
Copy link
Author

agajdosi commented May 30, 2018

@LalatenduMohanty TBH I do not fully understand the concept behind the fact oc provides information for STATUS (running, stopped, error...) and READY (0 or 1) for the pods. But it seems that after M start some pods are running, but sometimes are not ready, which causes troubles.

You can try with:

oc get pods -n default --as system:admin

@LalatenduMohanty LalatenduMohanty changed the title M openshift restart right after M start can break router and Docker registry pods "minishift openshift restart" right after "minishify start" make router and docker registry unusable May 31, 2018
@anjannath anjannath changed the title "minishift openshift restart" right after "minishify start" make router and docker registry unusable "minishift openshift restart" right after "minishift start" make router and docker registry unusable Jun 4, 2018
@LalatenduMohanty LalatenduMohanty modified the milestones: v1.19.0, v1.20.0 Jun 5, 2018
@anjannath anjannath modified the milestones: v1.20.0, v1.21.0 Jun 22, 2018
@LalatenduMohanty LalatenduMohanty modified the milestones: v1.22.0, v1.24.0 Jul 12, 2018
@LalatenduMohanty LalatenduMohanty modified the milestones: v1.24.0, v1.25.0 Aug 28, 2018
@stale
Copy link

stale bot commented Nov 13, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants