Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom exception class to catalogue python package #41

Open
2 tasks
LavMatt opened this issue Feb 20, 2024 · 0 comments
Open
2 tasks

Add custom exception class to catalogue python package #41

LavMatt opened this issue Feb 20, 2024 · 0 comments

Comments

@LavMatt
Copy link
Contributor

LavMatt commented Feb 20, 2024

User Story

As a developer
I want to add custom exception class to data-platform-catalogue
So that we have better defined errors for us and users

Value / Purpose

improve development and user experience

Useful Contacts

No response

User Types

No response

Hypothesis

If we raise an error via one of our client methods
Then we return enlightening information as to why

Proposal

No response

Additional Information

you can see example of how we currently handle errors here https://github.com/ministryofjustice/data-platform/blob/main/python-libraries/data-platform-catalogue/data_platform_catalogue/client/datahub/search.py#L80

Definition of Done

  • add custom exception class to package
  • make some tests for custom exceptions
@LavMatt LavMatt added the enhancement New feature or request label Feb 20, 2024
@moj-data-platform-robot moj-data-platform-robot transferred this issue from ministryofjustice/analytical-platform Apr 25, 2024
@seanprivett seanprivett removed the enhancement New feature or request label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants