-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs don't state the scope of the library #8
Comments
Also it would be useful to know that when new years are added will old ones be removed or left there. |
Hi @rmetcalf9 The read-me says that the library loads bank holidays from https://www.gov.uk/bank-holidays. It's up to the publishers of that website to decide what dates/years are available. You can subscribe to their calendar to know when they update official bank holiday lists. This library is designed to just be a convenience wrapper to their information. As for localisation, you don't have to provide a language but you can choose to do so. It defaults to English and Welsh is the only other language available. As it happens, the Welsh translations have been taken from Google Translate so can't necessarily be trusted! The language codes are the standard ones you'd see whenever dealing with localisation in python and in most other libraries/frameworks (ISO 639). If you'd like to improve the documentation, we'd welcome a pull request if it'd help others understand what's going on. |
I've added a note to the read-me about the 2 languages available. Hopefully that'll help people? |
When choosing to use the library I need to know:
The text was updated successfully, but these errors were encountered: