Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add badge component #26

Merged
merged 4 commits into from Jun 24, 2019
Merged

Add badge component #26

merged 4 commits into from Jun 24, 2019

Conversation

simonwhatley
Copy link
Contributor

Added:

  • Styles
  • Macro
  • Documentation

@simonwhatley simonwhatley self-assigned this Jun 13, 2019
@simonwhatley simonwhatley temporarily deployed to mojdt-frontend-staging-pr-26 June 13, 2019 11:06 Inactive
@simonwhatley simonwhatley temporarily deployed to mojdt-frontend-staging-pr-26 June 13, 2019 11:16 Inactive
@simonwhatley simonwhatley requested a deployment to mojdt-frontend-staging-pr-26 June 13, 2019 11:17 Abandoned
adamsilver
adamsilver previously requested changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@adamsilver adamsilver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be adding code into the design system that lets users use colours that have low contrast.

Also, this version of the badge is bigger (more like Tag) than the HMCTS badge. I think we should be aligning this to the HMCTS badge.

@simonwhatley simonwhatley temporarily deployed to mojdt-frontend-staging-pr-26 June 17, 2019 10:30 Inactive
@simonwhatley simonwhatley dismissed adamsilver’s stale review June 20, 2019 14:26

Low contrast colours have been removed from the badge styles.

@simonwhatley simonwhatley merged commit b633587 into master Jun 24, 2019
@simonwhatley simonwhatley deleted the component-badge branch June 26, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinwye gavinwye Awaiting requested review from gavinwye

@adamsilver adamsilver Awaiting requested review from adamsilver

Assignees

@simonwhatley simonwhatley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonwhatley @adamsilver