Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add organisation switcher #9

Merged
merged 2 commits into from Jun 10, 2019
Merged

Add organisation switcher #9

merged 2 commits into from Jun 10, 2019

Conversation

simonwhatley
Copy link
Contributor

Added:

  • Styles
  • Macro

Documentation to be added in a future PR

@simonwhatley simonwhatley added enhancement New feature or request and removed enhancement New feature or request labels Jun 7, 2019
@simonwhatley simonwhatley temporarily deployed to mojdt-frontend-staging-pr-9 June 10, 2019 08:33 Inactive
adamsilver
adamsilver reviewed Jun 10, 2019
View reviewed changes
Copy link
Contributor

@adamsilver adamsilver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. From a design pov, could you show me this working in context? The link is disconnected from the item which it relates to. So screen magnifier users might not realise that functionality is there on screen.

@gavinwye
Copy link
Contributor

@adamsilver Valid point, but we can document that as a known issue and fix it. Once we have teams using a consistent switcher it will be easy to change it.

@gavinwye gavinwye merged commit 1b36b6f into master Jun 10, 2019
@gavinwye gavinwye deleted the component-organisation-switcher branch June 10, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsilver adamsilver adamsilver left review comments

@gavinwye gavinwye Awaiting requested review from gavinwye

Assignees

@simonwhatley simonwhatley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simonwhatley @gavinwye @adamsilver