JOSS review: Installation

[DamienIrving]

@miniufo - well done on your submission to JOSS.

As part of my review of your submission (see openjournals/joss-reviews#5510), I have some questions/suggestions regarding software installation:

• In the "how to install" (https://github.com/miniufo/xinvert#2-how-to-install) section of your README file it says "install via pip (not yet)" but as far as I can tell it can be installed by pip. What is the meaning of "not yet"?
• Do you think it would be advantageous to also make the package available via conda (i.e. conda-forge) for users who manage their python environments using conda?

[miniufo]

• that's right. I forgot to update this. (not yet) should be removed.
• Definitely should be in conda. Right now I send a PR to conda for another package here, which is the first time I do this. I am not sure how long it would take (or maybe I do something incorrect). Maybe you can point me to the right path on how to make xinvert available via conda.

[DamienIrving]

Your xgrads PR looks fine to me - hopefully they will action it soon.

Since xinvert is available via pip I don't think waiting for it to be available via conda should delay your JOSS publication. It would be nice to have it available via conda eventually, but it's not absolutely necessary for publication with JOSS.

[miniufo]

That's great. I'll follow the steps of xgrads and make a PR of adding xinvert to conda recipe.

[miniufo]

Hi @DamienIrving, I've removed 'not yet' in the README.md. Also, I've sent a PR to conda recipe, waiting it to be merged. Please see if this issue is fixed now.

[DamienIrving]

Awesome. Thanks, @miniufo.